Repository navigation
Conversation
LocalSession::EncodeReturn passes an object return as (type_index, handle) since the RPC moved to the new FFI ABI. The wasm session's time evaluator path still read the first value as the function, so it always got null and the browser runtime aborted on the check. Any time_evaluator call over the WebSocket RPC hung on the Python side. Read the handle from the second value, where EncodeReturn puts it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalSession::EncodeReturnpasses an object return as(type_index, handle)since #17931 moved the RPC to the new FFI ABI. The wasm session's time evaluator path inweb/emcc/tvmjs_support.ccstill read the first value as the function, so it always got null and the browser runtime aborted withCheck failed: (pf != nullptr). Anytime_evaluatorcall over the WebSocket RPC then hung on the Python side.Read the handle from the second value. The other async return path in the same session already forwards the
EncodeReturnoutput unchanged.Tested by building the web runtime with Emscripten 4.0.23, connecting the browser RPC page in Chrome with WebGPU on an Apple M4 Pro, and timing a ragged prefill kernel over RPC with
time_evaluator. Before this change the browser aborted on the first call. After it, the timer returns and the kernel output matches a NumPy reference. pre-commit checks pass.